New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch on tapbacks when a photo is sent together with a text message. #542
Comments
Hmmm ok, this is more of a design choice decision, but yes it definitely is very easy to do. Should we do it like how iOS does it? It's not really a mismatch, more of like a decision on which to put the reaction, because the image is part of the message, so does the image get the reaction or does the text? |
I think the photo and text should have the ability to be treated as a separate message. For example on the latest nightly, long pressing for a reaction on either the text or the photo gives me the same option |
I just had a similar problem with two photos that were sent together, I wanted to put different tapbacks on each photo but the two photos were treated as one message |
Well that's just not how iMessage works, they are essentially the same message, the message just has an attachment |
Ah shoot. Okay I understand, I'll close this then |
Reopening because I was just sent 4 pictures and wanted to add different tapbacks to each photo, but all 4 were treated as one message. |
Even though it is one message with multiple parts, I still feel that each piece of the message should have the individual ability to have a tapback on it |
Also mentioned here |
sgtaziz/WebMessage#51 (comment) |
Here is a similar issue in SMServer, as well as the same issue in WebMessage {
"id": "D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
"fromMe": true,
"isTypingMessage": false,
"description": "We'll show up and he'll be like",
"flags": 1081349,
"fileTransferIDs": [
"72D48466-A535-4C93-AA78-6791A8AB53F1"
],
"chatID": "chat526745548997352517",
"time": 1615577622383.0002,
"timeRead": 0,
"isSOS": false,
"timeDelivered": 0,
"isAudioMessage": false,
"isCancelTypingMessage": false,
"items": [
{
"type": "attachment",
"payload": {
"metadata": {
"size": {
"width": 500,
"height": 255
},
"id": "72D48466-A535-4C93-AA78-6791A8AB53F1",
"filename": "AE5727AE-29A7-4E84-B537-17AFD35FEB41.gif",
"uti": "com.compuserve.gif",
"mime": "image/gif"
},
"id": "p:0/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
"chatID": "chat526745548997352517",
"transferID": "72D48466-A535-4C93-AA78-6791A8AB53F1",
"fromMe": true,
"time": 1615577622383.0002
}
},
{
"type": "text",
"payload": {
"chatID": "chat526745548997352517",
"fromMe": true,
"parts": [
{
"type": "text",
"string": "We'll show up and he'll be like"
}
],
"id": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
"time": 1615577622383.0002,
"text": "We'll show up and he'll be like",
"acknowledgments": [
{
"chatID": "chat526745548997352517",
"sender": "*my friend's email*",
"associatedID": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
"id": "am:F0716C13-6871-4286-A4A6-3CF3FB0B25CD",
"fromMe": false,
"time": 1615577636093.2012,
"acknowledgmentType": 2003
}
]
}
}
],
"service": "iMessage",
"timePlayed": 0,
"sender": "e:*my email*",
"isDelivered": false
} |
open-imcore/imcore.react#8 (comment) Also issue #714 |
Is it okay to close this issue? |
Not yet. Needs to be implemented client-side |
Completed in full rewrite |
This isn't a huge deal, and I had this problem in AirMessage too (however, when sending a photo with text in BlueBubbles, the photo sends first and then the text which I think is done much better than AirMessage sending the text first).
So here on iOS we can see the tapbacks go with the text, not the image, but on BlueBubbles, the tapbacks show up on the image. Also, would it be possible to group the tapbacks into numbered clutters? Thanks for everything and good luck on finals,
The text was updated successfully, but these errors were encountered: