Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch on tapbacks when a photo is sent together with a text message. #542

Closed
sabogalc opened this issue Dec 9, 2020 · 17 comments
Closed
Labels
Bug Something isn't working Difficulty: Hard When a ticket is deemed hard to do UX Issues having to do with user-experience

Comments

@sabogalc
Copy link

sabogalc commented Dec 9, 2020

This isn't a huge deal, and I had this problem in AirMessage too (however, when sending a photo with text in BlueBubbles, the photo sends first and then the text which I think is done much better than AirMessage sending the text first).

So here on iOS we can see the tapbacks go with the text, not the image, but on BlueBubbles, the tapbacks show up on the image. Also, would it be possible to group the tapbacks into numbered clutters? Thanks for everything and good luck on finals,

  • CSab

iOS 1
iOS 2
Android 1
Android 2

@Bricktheworld
Copy link
Contributor

Hmmm ok, this is more of a design choice decision, but yes it definitely is very easy to do. Should we do it like how iOS does it? It's not really a mismatch, more of like a decision on which to put the reaction, because the image is part of the message, so does the image get the reaction or does the text?

@sabogalc
Copy link
Author

I think the photo and text should have the ability to be treated as a separate message. For example on the latest nightly, long pressing for a reaction on either the text or the photo gives me the same option

@sabogalc
Copy link
Author

I just had a similar problem with two photos that were sent together, I wanted to put different tapbacks on each photo but the two photos were treated as one message

@Bricktheworld
Copy link
Contributor

I think the photo and text should have the ability to be treated as a separate message. For example on the latest nightly, long pressing for a reaction on either the text or the photo gives me the same option

Well that's just not how iMessage works, they are essentially the same message, the message just has an attachment

@sabogalc
Copy link
Author

Ah shoot. Okay I understand, I'll close this then

@sabogalc sabogalc reopened this Dec 25, 2020
@sabogalc
Copy link
Author

Reopening because I was just sent 4 pictures and wanted to add different tapbacks to each photo, but all 4 were treated as one message.

@sabogalc
Copy link
Author

Even though it is one message with multiple parts, I still feel that each piece of the message should have the individual ability to have a tapback on it

@sabogalc
Copy link
Author

Also mentioned here

@sabogalc
Copy link
Author

sgtaziz/WebMessage#51 (comment)
sgtaziz fixed this in WebMessage, however since that server runs on iOS and this one runs on macOS I'm not sure how comparable the code is

@sabogalc
Copy link
Author

sabogalc commented Mar 16, 2021

Here is a similar issue in SMServer, as well as the same issue in WebMessage
Here are some images for how it shows up on BB Android, BB Desktop, and my Mac
Screenshot_20210316-160900
Screenshot 2021-03-16 170034
Screen Shot 2021-03-16 at 4 58 52 PM
Also, the GIF moves on desktop, but not on Android. This is what happens when I tap on the photo to open it in Android
gif
Using the Re-download from Server button didn't fix it

{
  "id": "D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
  "fromMe": true,
  "isTypingMessage": false,
  "description": "We'll show up and he'll be like",
  "flags": 1081349,
  "fileTransferIDs": [
    "72D48466-A535-4C93-AA78-6791A8AB53F1"
  ],
  "chatID": "chat526745548997352517",
  "time": 1615577622383.0002,
  "timeRead": 0,
  "isSOS": false,
  "timeDelivered": 0,
  "isAudioMessage": false,
  "isCancelTypingMessage": false,
  "items": [
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 500,
            "height": 255
          },
          "id": "72D48466-A535-4C93-AA78-6791A8AB53F1",
          "filename": "AE5727AE-29A7-4E84-B537-17AFD35FEB41.gif",
          "uti": "com.compuserve.gif",
          "mime": "image/gif"
        },
        "id": "p:0/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
        "chatID": "chat526745548997352517",
        "transferID": "72D48466-A535-4C93-AA78-6791A8AB53F1",
        "fromMe": true,
        "time": 1615577622383.0002
      }
    },
    {
      "type": "text",
      "payload": {
        "chatID": "chat526745548997352517",
        "fromMe": true,
        "parts": [
          {
            "type": "text",
            "string": "We'll show up and he'll be like"
          }
        ],
        "id": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
        "time": 1615577622383.0002,
        "text": "We'll show up and he'll be like",
        "acknowledgments": [
          {
            "chatID": "chat526745548997352517",
            "sender": "*my friend's email*",
            "associatedID": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
            "id": "am:F0716C13-6871-4286-A4A6-3CF3FB0B25CD",
            "fromMe": false,
            "time": 1615577636093.2012,
            "acknowledgmentType": 2003
          }
        ]
      }
    }
  ],
  "service": "iMessage",
  "timePlayed": 0,
  "sender": "e:*my email*",
  "isDelivered": false
}

@sabogalc
Copy link
Author

@sabogalc
Copy link
Author

open-imcore/imcore.react#8 (comment) Also issue #714
BlueBubbles 3
PNG image (1)

@sabogalc
Copy link
Author

sabogalc commented May 16, 2021

Here's another situation with one message that has multiple parts (this time both text and attachments)

Here is the conversation on iOS
iOS
and in BlueBubbles
BlueBubbles
Below is some message information that I copied from MyMessage

{
  "id": "28935DBA-A57E-485E-9442-10FBAD3A3C95",
  "fromMe": true,
  "isTypingMessage": false,
  "description": "Here is a message that has images intermittently scattered throughout it",
  "flags": 1085445,
  "fileTransferIDs": [
    "49CA2847-DF32-4D66-9857-7163EE1FCE49",
    "9C606BB6-2443-4101-A55A-8E2610D08988",
    "00A6CB41-165B-43B8-881F-59D725515B36"
  ],
  "chatID": "*recipient*",
  "time": 1620776404411,
  "timeRead": 0,
  "isSOS": false,
  "timeDelivered": 1620776405263.5593,
  "isAudioMessage": false,
  "isCancelTypingMessage": false,
  "items": [
    {
      "type": "text",
      "payload": {
        "id": "p:0/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "Here is a message"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "Here is a message"
      }
    },
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 200,
            "height": 200
          },
          "id": "49CA2847-DF32-4D66-9857-7163EE1FCE49",
          "filename": "IMG_1752.png",
          "uti": "public.png",
          "mime": "image/png"
        },
        "id": "p:1/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "transferID": "49CA2847-DF32-4D66-9857-7163EE1FCE49",
        "fromMe": true,
        "time": 1620776404411
      }
    },
    {
      "type": "text",
      "payload": {
        "id": "p:2/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "that has images"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "that has images"
      }
    },
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 200,
            "height": 200
          },
          "id": "9C606BB6-2443-4101-A55A-8E2610D08988",
          "filename": "IMG_3897.png",
          "uti": "public.png",
          "mime": "image/png"
        },
        "id": "p:3/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "transferID": "9C606BB6-2443-4101-A55A-8E2610D08988",
        "fromMe": true,
        "time": 1620776404411
      }
    },
    {
      "type": "text",
      "payload": {
        "id": "p:4/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "intermittently scattered"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "intermittently scattered"
      }
    },
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 200,
            "height": 200
          },
          "id": "00A6CB41-165B-43B8-881F-59D725515B36",
          "filename": "IMG_4390.png",
          "uti": "public.png",
          "mime": "image/png"
        },
        "id": "p:5/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "transferID": "00A6CB41-165B-43B8-881F-59D725515B36",
        "fromMe": true,
        "time": 1620776404411
      }
    },
    {
      "type": "text",
      "payload": {
        "id": "p:6/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "throughout it"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "throughout it"
      }
    }
  ],
  "service": "iMessage",
  "timePlayed": 0,
  "sender": "*me*",
  "isDelivered": true
}

@zlshames zlshames added Bug Something isn't working Difficulty: Hard When a ticket is deemed hard to do UX Issues having to do with user-experience labels Jun 17, 2021
@sabogalc
Copy link
Author

sabogalc commented Jul 7, 2021

Another example. I wanted to place different tapbacks on each of these images, but BlueBubbles groups all of the images into one message that can only receive one tapback.
Screenshot_20210707-174253

@sabogalc
Copy link
Author

sabogalc commented Oct 5, 2022

Is it okay to close this issue?

@zlshames
Copy link
Member

zlshames commented Oct 5, 2022

Not yet. Needs to be implemented client-side

@tneotia tneotia added this to the v1.11 Full Rewrite milestone Nov 9, 2022
@tneotia
Copy link
Member

tneotia commented Nov 22, 2022

Completed in full rewrite

@tneotia tneotia closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Difficulty: Hard When a ticket is deemed hard to do UX Issues having to do with user-experience
Projects
Development

No branches or pull requests

4 participants