feat: make returned data from parse_advertisement_data readonly #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 99.42% 99.45% +0.02%
==========================================
Files 3 3
Lines 175 182 +7
Branches 25 26 +1
==========================================
+ Hits 174 181 +7
Misses 1 1
☔ View full report in Codecov by Sentry. |
bdraco
force-pushed
the
readonly
branch
2 times, most recently
from
946c29b
to
2f9997f
Compare
The cython fields should have been marked as readonly. They are also available as a tuple as parse_advertisement_data_tuple for rapid unpacking of many advertisements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cython fields should have been marked as readonly to prevent mistakes. They are also available as a tuple as parse_advertisement_data_tuple for rapid unpacking of many advertisements