feat: speed up the new parse_advertisement_data_tuple function #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is technically a breaking change to only allow incoming data to be a tuple, but since its new and likely only HA is using it, I did not bump the major version
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 99.45% 99.44% -0.01%
==========================================
Files 3 3
Lines 182 180 -2
Branches 26 25 -1
==========================================
- Hits 181 179 -2
Misses 1 1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change to only allow incoming data to be a tuple, but since its new (less than 2 weeks old) and only in HA dev, and likely only HA is using it, I did not bump the major version.
Before
Parsing 100000 bluetooth messages took 0.047129874998063315 seconds
Parsing 100000 bluetooth messages took 0.04788412500056438 seconds
Parsing 100000 bluetooth messages took 0.048007541001425125 seconds
After
Parsing 100000 bluetooth messages took 0.0215528330008965 seconds
Parsing 100000 bluetooth messages took 0.022052750002330868 seconds
Parsing 100000 bluetooth messages took 0.02225575000193203 seconds