Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow one encryption counter reset per 100 messages to allow changing… #117

Closed
wants to merge 8 commits into from

Conversation

Komzpa
Copy link

@Komzpa Komzpa commented Mar 24, 2024

… batteries and brownouts in devices

Attempt to fix #116. Thanks ChatGPT for help. Did not try running this, please review if this makes sense.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.11%. Comparing base (303f833) to head (69a1fa0).
Report is 1 commits behind head on main.

❗ Current head 69a1fa0 differs from pull request most recent head b53d8d7. Consider uploading reports for the commit b53d8d7 to get more accurate results

Files Patch % Lines
src/bthome_ble/parser.py 57.14% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   83.84%   83.11%   -0.74%     
==========================================
  Files           6        6              
  Lines         520      533      +13     
  Branches       79       82       +3     
==========================================
+ Hits          436      443       +7     
- Misses         68       73       +5     
- Partials       16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Ernst79 Ernst79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some linting issues (see the first CI / lint test). You should also add tests to see if this works as expected.
And some testing on your own system would be helpful to verify that we don't break stuff for other users.

@Komzpa
Copy link
Author

Komzpa commented Mar 30, 2024

I managed to run this on my instance and it does not yet fix the issue. Will continue torturing this.

image

@Komzpa
Copy link
Author

Komzpa commented Apr 15, 2024

I believe version in #119 came out a lot nicer than this approach.

@Komzpa Komzpa closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing batteries in thermometer breaks encrypyion
2 participants