Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid enum dunder overhead in message_bus calls #187

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 9, 2022

call_overhead

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 82.55% // Head: 82.20% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (a22f811) compared to base (fb0cc35).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   82.55%   82.20%   -0.35%     
==========================================
  Files          27       27              
  Lines        3153     3153              
  Branches      651      651              
==========================================
- Hits         2603     2592      -11     
- Misses        338      343       +5     
- Partials      212      218       +6     
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/aio/message_bus.py 85.71% <100.00%> (-0.07%) ⬇️
src/dbus_fast/aio/proxy_object.py 96.55% <100.00%> (+0.06%) ⬆️
src/dbus_fast/glib/message_bus.py 80.32% <0.00%> (-2.05%) ⬇️
src/dbus_fast/message_bus.py 71.48% <0.00%> (-1.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review December 9, 2022 19:15
@bdraco bdraco merged commit b3c7d51 into main Dec 9, 2022
@bdraco bdraco deleted the enum_dunder branch December 9, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant