Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more cython3 optional fixes #219

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix: more cython3 optional fixes #219

merged 2 commits into from
Aug 2, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 2, 2023

there were a few more places that were missing optional which is now strictly enforced with cython3

there were a few more places that were missing optional
src/dbus_fast/introspection.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.25% ⚠️

Comparison is base (7826897) 82.73% compared to head (7b0be3f) 82.48%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   82.73%   82.48%   -0.25%     
==========================================
  Files          27       27              
  Lines        3220     3220              
  Branches      668      668              
==========================================
- Hits         2664     2656       -8     
- Misses        342      346       +4     
- Partials      214      218       +4     
Files Changed Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/aio/message_reader.py 90.90% <ø> (ø)
src/dbus_fast/glib/message_bus.py 80.32% <ø> (-2.05%) ⬇️
src/dbus_fast/aio/message_bus.py 85.57% <100.00%> (ø)
src/dbus_fast/auth.py 87.93% <100.00%> (ø)
src/dbus_fast/introspection.py 84.92% <100.00%> (ø)
src/dbus_fast/service.py 88.65% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 5b6cbc5 into main Aug 2, 2023
13 of 15 checks passed
@bdraco bdraco deleted the cython3_fixes branch August 2, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant