Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paralellisation with OpenMP #18

Open
Blunde1 opened this issue May 24, 2020 · 2 comments
Open

Add paralellisation with OpenMP #18

Blunde1 opened this issue May 24, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Blunde1
Copy link
Owner

Blunde1 commented May 24, 2020

The node::split_information()should be easy to paralellize.

@Blunde1 Blunde1 added the enhancement New feature or request label May 24, 2020
@szilard
Copy link

szilard commented Sep 4, 2020

Indeed, and up to 4-8 threads/CPU cores it can have a very good benefit, though based on experience with xgboost/lightgbm the scaling beyond 8 cores is difficult/with very much diminishing returns for dataset sizes commonly found in practice (100K-1M records):

Screen Shot 2020-09-04 at 2 37 31 AM

(the panels are for various dataset sizes, 0.1M (million) rows, 1M and 10M)

@szilard
Copy link

szilard commented Sep 4, 2020

Also there is an actual slow down on systems with multi-CPU sockets (even for super-large datasets) for example xgboost and lightgbm are not "NUMA optimized":

Screen Shot 2020-09-04 at 2 41 02 AM
Screen Shot 2020-09-04 at 2 41 25 AM

More details in this repo https://github.com/szilard/GBM-perf#multi-socket-cpus or in this talk https://www.youtube.com/watch?v=qjuizRba3ZQ&t=31m00s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants