A couple of fixes, update API target to Android 4.4 #25
Conversation
| @@ -28,6 +28,6 @@ | |||
| android:versionCode="1" | |||
| android:versionName="1.0" > | |||
|
|
|||
| <uses-sdk android:minSdkVersion="7" /> | |||
| <uses-sdk android:minSdkVersion="7" android:targetSdkVersion="17" /> | |||
There was a problem hiding this comment.
I'm not sure this attribute is useful for a library, but in any case I guess you meant 19?
There was a problem hiding this comment.
You're right, I've missed that. Shouldn't make a big difference here anyway, as you're pointing out :)
There was a problem hiding this comment.
Do you want me to fix it or are you going to do it if/when you merge?
There was a problem hiding this comment.
I would prefer if you could fix it :) Thanks.
There was a problem hiding this comment.
Ok, will do today :)
|
Thank you for this! Other than the little remark above, I would gladly merge the changes. |
|
Fixed the Manifest typo :) |
|
Oh, missing from the OP but in the commits, in this pull request I've also fixed the switch text color (which would show up as black on light themes, and now is always the right light grey shade) and included KitKat's XXHDPI drawables. Since those drawables are the same from API 16 onwards, instead of having them in a |
A couple of fixes, update API target to Android 4.4
|
Thanks a lot for this high quality contribution :) |
|
You're welcome! Thanks for sharing the library :) |
|
Actually, the text color for the light theme was incorrect! No worries, I just fixed it in the 1.3 release :) |
|
I'm sorry, totally missed it... |
This is the full list of changes:
+from the layout files' id fields (they're already defined, you shouldn't have the plus in there)targetSdkVersionandcompileSdkVersion)defaultConfigto match what is declared in the ManifestSwitchclass code: now it uses the original API calls that were substituted in the backporting process if running on a platform version that supports them; removed some code inonMeasurethat wasn't actually used for anythingThe Gradle changes should be fine as they're pretty basic but I haven't had the chance to test them as much as I'd like. I am not confident with Maven, so that will need someone else to work on it.