New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Archive is broken #505
Comments
I guess Bob should move to the new API. Reimplementing the REST-API is probably not a viable option. |
@sbixl I made some tests but it would be nice if you could test the changes too... |
I am currently having problems with my CI environment but at first glance the changes are working. The upload to the Azure account works without problems (tested with this). The download I can currently not test. I hope I get the problem solved over the weekend and can give feedback by the end of next week. |
Uploading and downloading to an Azure blob container works fine. :-) The only thing I noticed is that downloading an artifact takes much longer when working with the archive Archive type: azure
Archive type: http
Do you have any idea why? I suspect that this has nothing to do with the implementation. |
I think I found a possible problem that could cause the download speed issues. The Azure classes seem to implement a synchronous read() which implies a full roundtrip to the server. I added a buffer that should hide this problem. Let me know if this improves the performance for you. |
Looks much better now:
Thanks for fixing that issue! :-) |
Thanks for testing. |
Hi,
the Azure archive handling is broken, because the implementation depends on a (in the meantime) deprecated pip package
azure-storage
[1]. The import ofBlockBlobService
in the new pip packageazure-storage-blob
is not supported and theContainerClient
shall be used instead [2]. I studied the implementation of the classAzureArchive
a little bit and it seems to be a bit more refactoring is required in order to switch to the new API. So I did not think I could provide a suitable pull request.[1] https://stackoverflow.com/questions/58900507/upload-and-delete-azure-storage-blob-using-azure-storage-blob-or-azure-storage/58900508#58900508
[2] https://azuresdkdocs.blob.core.windows.net/$web/python/azure-storage-blob/12.0.0b5/azure.storage.blob.html#azure.storage.blob.ContainerClient
PS: If there is a bugfix available I can help with testing of up- and downloads of artifacts.
Regards,
Sebastian
The text was updated successfully, but these errors were encountered: