fix #572: [FR] Tweak handling of the 'composé de' template

[lasconic]

• Fixes [FR] Tweak handling of the 'composé de' template #572
• Tests added/updated.
• ./check.sh run and eventual issues fixed.
• Updated CONTRIBUTORS.md, if not already done in the past.

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.27%.

Quality metrics	Before	After	Change
Complexity	17.31 🙂	16.43 🙂	-0.88 👍
Method Length	80.38 🙂	81.28 🙂	0.90 👎
Working memory	9.97 😞	9.73 🙂	-0.24 👍
Quality	56.27% 🙂	56.54% 🙂	0.27% 👍

Other metrics	Before	After	Change
Lines	616	650	34

Changed files	Quality Before	Quality After	Quality Change
wikidict/lang/fr/template_handlers.py	56.27% 🙂	56.54% 🙂	0.27% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
wikidict/lang/fr/template_handlers.py	render_compose_de	51 ⛔	490 ⛔	15 😞	12.05% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py	render_etyl	17 🙂	161 😞	10 😞	46.13% 😞	Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py	render_mot_valise	13 🙂	126 😞	10 😞	53.27% 🙂	Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py	render_cit_ref	10 🙂	169 😞	8 🙂	55.58% 🙂	Try splitting into smaller methods
wikidict/lang/fr/template_handlers.py	render_agglutination	12 🙂	102 🙂	10 😞	57.22% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[lasconic]

This function could be out of the render_compose_de function and be reused in other templates such as etyl.
However, it's a hack regarding the italic handling. The right way to do it it's to check if each char of the words are "Latin", "Common" or "Inherited" in the script ranges from https://fr.wiktionary.org/wiki/Module:donn%C3%A9es_Unicode/data/script_ranges

I tried another way in render_etyl but it's not working for d’ (not the apostrophe...)

@BoboTiG WDYT ?

[BoboTiG]

We could move the function and handle unicode chars correctly, yes. It could be done in another PR to keep this one as-is (already quite complex).

[BoboTiG]

What an horrible template to handle :)

[lasconic]

Yes... it could be made more "python" I guess, but I also see some value in being close to the wikicode...

[BoboTiG]

I was not talking about the code ;)
But the model is doing so much stuff that handling it is quite ugly.

Anyway, good work 👍 :)