Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix values computation in the info bar #2

Closed
BoboTiG opened this issue May 22, 2022 · 0 comments
Closed

Fix values computation in the info bar #2

BoboTiG opened this issue May 22, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@BoboTiG
Copy link
Owner

BoboTiG commented May 22, 2022

There is a mismatch with the Rust version: when displaying the info bar, our version is computing values using the visible candle set. Actually, it should rather use the main candle set.

Our version (incorrect):

def render(self, candle_set: "CandleSet") -> str:

Rust version (correct): https://github.com/Julien-R44/cli-candlestick-chart/blob/9ea785c1a9fe5e2357bfe1411150ad0a7e009135/src/info_bar.rs#L19

@BoboTiG BoboTiG added the bug Something isn't working label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant