Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If possible, make building without bobril-build possible. #100

Closed
MicahZoltu opened this issue Sep 23, 2019 · 6 comments
Closed

If possible, make building without bobril-build possible. #100

MicahZoltu opened this issue Sep 23, 2019 · 6 comments

Comments

@MicahZoltu
Copy link

At the moment, the bobril NPM package doesn't contain compiled output. It only contains index.ts. What is worse is that the package.json references main: 'index.js' which doesn't exist in the package (I'm surprised NPM let you publish like this).

If it is possible, it would be nice to be able to use this without having to use the custom tooling. I believe at the least this requires publishing NPM packages with pre-compiled index.js (this may require other changes as well, not sure).

@Bobris
Copy link
Owner

Bobris commented Sep 23, 2019

Hi, it is carefully stripped to make it as small as possible saving developers disk space. Would changing main to 'index.ts' help you in any way?

@MicahZoltu
Copy link
Author

Probably not. The main pointing at a non-existent index.js is just an invalid package.json.

On the more relevant topic of the missing index.js, is there a reason you don't distribute JS? Is there something about the way Bobril works that makes it so it wouldn't work if the JS was shipped with the NPM package?

@Bobris
Copy link
Owner

Bobris commented Sep 24, 2019

It would work of course, just that for intended usage with bobril-build it is useless and it just increase package size. But will consider to include it at least minified so it will not increase size too much.

@MicahZoltu
Copy link
Author

What is the concern with increasing the NPM package size? I can understand wanting to avoid increasing the size of the deployed code, but increasing an NPM package size from 300KB to 600KB feels unnecessary, especially when it prevents people from being able to use the library without custom build tooling.

@Bobris
Copy link
Owner

Bobris commented Oct 5, 2019

Will be implemented in version 13.0 roughly in week.

@Bobris
Copy link
Owner

Bobris commented Oct 14, 2019

Published in 13.0.0 beta

@Bobris Bobris closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants