Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Codes #10

Closed
Bobspadger opened this issue Mar 29, 2018 · 2 comments
Closed

Error Codes #10

Bobspadger opened this issue Mar 29, 2018 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Bobspadger
Copy link
Owner

Instead of using requests.raise_for_status() maybe inspect the error code, and return the friendly error along with an exception to enable better and easier access

@Bobspadger Bobspadger added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 29, 2018
@Bobspadger
Copy link
Owner Author

This shows itself as not being the best way to handle errors as it wipes the json and the helpful errors out from the 400 response.

these can contain helpful information such as 'Email required'

@Bobspadger
Copy link
Owner Author

#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant