Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: use styled-components for styling #7

Open
ghsamm opened this issue Jan 18, 2019 · 2 comments
Open

suggestion: use styled-components for styling #7

ghsamm opened this issue Jan 18, 2019 · 2 comments

Comments

@ghsamm
Copy link
Contributor

ghsamm commented Jan 18, 2019

I have been using styled-components for a while now and I think it's the best tool for styling React components.

I have even prepared a presentation about styled-components, check it out: https://paper.dropbox.com/doc/Go-My-Code-webinars-styled-components-with-Sam--AV03sRyI~PeudxfaYB~7nOYwAQ-QAt6W9GiJlN6U06ExXVey

what do you think ?

@Bogdan-Lyashenko
Copy link
Owner

@ghsamm, thanks for bringing this, you may be right. When it was the last time I worked with styled-components Webstorm (code editor I use) had no support for syntax highlight/autocomplete (because it's string), that was a main thing I didn't like. Also, since half of CSS in codecrumbs are styles for SVG I want to have it as pure as possible, because of performance concerns (SVG tree can be super big for big codebase).
Anyway, let's keep this issue open, we might migrate to styled-components later when see it brings benefits or next time we do major refactoring, right now it's just too much hight prio work to be done apart of styled-components 😸

@popuguytheparrot
Copy link

В webstorm есть плагин. Называется styled-components. Добавляет автокомплит и все такое

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants