Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing: improved mypy support #482

Merged
merged 7 commits into from Mar 18, 2022
Merged

typing: improved mypy support #482

merged 7 commits into from Mar 18, 2022

Conversation

staticdev
Copy link
Contributor

@staticdev staticdev commented Mar 15, 2022 •
edited

  • py.typed mark as required by PEP-561
  • add mypy.ini config
  • fix JSONEncoder error handling
  • some mypy error fixes
  • some isort error fixes

Closes #305

@staticdev staticdev changed the title Typing/improved mypy support typing: improved mypy support Mar 15, 2022
@staticdev
Copy link
Contributor Author

staticdev commented Mar 15, 2022 •
edited

@Bogdanp there is still a lot of typing missing, but this PR will remove some complaints from mypy of when you import dramatiq. I will follow up with other PRs if we can get things going.

CaselIT
CaselIT suggested changes Mar 16, 2022
View reviewed changes
dramatiq/broker.py Outdated Show resolved Hide resolved
dramatiq/results/backends/stub.py Outdated Show resolved Hide resolved
@staticdev
Copy link
Contributor Author

LGTM? @CaselIT @Bogdanp

@Bogdanp Bogdanp merged commit 31053af into Bogdanp:master Mar 18, 2022
@staticdev staticdev deleted the typing/improved-mypy-support branch March 24, 2022 21:39
@staticdev
Copy link
Contributor Author

staticdev commented Mar 24, 2022 •
edited

@Bogdanp could we get a new release with latest commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaselIT CaselIT CaselIT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing support for the public API
3 participants
@staticdev @CaselIT @Bogdanp