Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that watch is not supported on windows #326

Closed
CaselIT opened this issue Jul 12, 2020 · 3 comments · Fixed by #328
Closed

Document that watch is not supported on windows #326

CaselIT opened this issue Jul 12, 2020 · 3 comments · Fixed by #328

Comments

@CaselIT
Copy link
Contributor

CaselIT commented Jul 12, 2020

Issues

Watch requires the signal SIGHUP that is only available on unix type system.

What OS are you using?

windows

What version of Dramatiq are you using?

1.9.0

What did you do?

started dramatiq with the --watch option and modified the files causing a reload

What did you expect would happen?

The code would reload. Or a meaningful error would be raised.

What happened?

The excection AttributeError: module 'signal' has no attribute 'SIGHUP' is raised.

While it would be nice to have support for reload on windows, I think its would be ok to just document that watch is not supported in dramatiq --help and maybe ignore the flag on windows or raise a more meaningful exception than the attribute error

@Bogdanp
Copy link
Owner

Bogdanp commented Jul 13, 2020

This makes sense to me. Would you like to make these changes?

@CaselIT
Copy link
Contributor Author

CaselIT commented Jul 13, 2020

Ok, I'll have a look at it. I think that documenting that watch on windows is not supported and ignore the flag would be preferred option for now? Alternatively I'm not sure if we could change SIGHUP for another signal on windows to make watch work?

@Bogdanp
Copy link
Owner

Bogdanp commented Jul 13, 2020

I think that documenting that watch on windows is not supported and ignore the flag would be preferred option for now?

Yep. That sounds like the right approach. Maybe raise a specific error when --watch is set on Windows instead of ignoring it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants