Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs: 'new-button (send tab-panel on-new-request) not implemented #19

Closed
benknoble opened this issue May 11, 2022 · 3 comments
Closed

Comments

@benknoble
Copy link
Contributor

'can-reorder 'can-close 'new-button

The documentation mentions 'new-button, but the implementation does not yet support it. Fortunately I can add it to my application in other ways, so perhaps a quick update to the doc is all that is needed?

@benknoble benknoble changed the title 'new-button (send tab-panel on-new-request) not implemented tabs: 'new-button (send tab-panel on-new-request) not implemented May 11, 2022
@Bogdanp Bogdanp reopened this May 12, 2022
@Bogdanp
Copy link
Owner

Bogdanp commented May 12, 2022

Whoops, I closed this prematurely. I've changed the contract to allow 'new-button, but need to implement the hook still.

@Bogdanp
Copy link
Owner

Bogdanp commented May 12, 2022

OK, I've now pushed a change to handle the new button event. The action on tabs can now receive 'new events as well.

@Bogdanp Bogdanp closed this as completed May 12, 2022
@benknoble
Copy link
Contributor Author

Thanks!

Tangentially, I did learn from @mflatt (https://github.com/mflatt) that on macOS 'can-close only works with 'no-border, and it appears you cannot close the last tab, so depending on the desired behavior this may be another of those "add this behavior in other ways."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants