Improve handling of export errors #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
mathieudutour
suggested changes
Mar 20, 2019
| // export the layers | ||
| if (layers.length) { | ||
| exporter.exportLayers(layers) | ||
| try { |
There was a problem hiding this comment.
I'm not too sure about wrapping everything in try/catch. That breaks any optimizations the compiler can make.
I'd rather explicitly check for it:
if (!nativeObjects.parentPage()) {
throw error
}There was a problem hiding this comment.
I started going that route but then realized there are some edge cases in there. For example, some cases don't need a parent. This seemed less likely to cause conflicts if the internals were to change (except the error messages of course but that is covered by the tests).
Any idea what that difference in optimizations would be? Significant for this?
Closed
|
Closing for now. May revisit at a later point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap native export calls in try catch and convert native exceptions to more helpful error messages.
Converting the native errors seemed to be the easiest way to handle this.
See: https://sketch-friends.slack.com/archives/C5YKGT26B/p1552063120097100