Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsive font controls #84

Closed
boldgrid-support opened this issue May 3, 2019 · 7 comments · Fixed by #550
Closed

Add responsive font controls #84

boldgrid-support opened this issue May 3, 2019 · 7 comments · Fixed by #550
Labels
Projects
Milestone

Comments

@boldgrid-support
Copy link

Is your feature request related to a problem? Please describe.
Some Headings are too large when viewed on a mobile screen and there is no option to set specific font sizes for various devices.

Describe the solution you'd like
Add controls in the Customizer to allow for site wide defaults to control fonts across the range of devices.

Describe alternatives you've considered
Currently you need to use custom CSS code to address these display problems.

@timelsass timelsass transferred this issue from BoldGrid/prime May 3, 2019
@timelsass timelsass changed the title Feature: Add responsive font controls Add responsive font controls May 3, 2019
@timelsass
Copy link
Member

This is dependent on quite a few other changes that have to happen, but typography is something that needs to be changed. I don't think we will add controls for different viewport sizes in the theme though, but it is a possibility.

Just as an initial idea, I originally thought of doing something along the lines of this pen:
https://codepen.io/times/pen/qGWXer

That's using the typography scale defined for heading sizes(bootstrap), but I'd like to introduce some "scale" controls which would change the typography rhythm used. As an example of this, look at the site modularscale.com.

Overall, I'd like to see a solution taking the typography scales mentioned above, and then setting some minimum and maximum thresholds for the viewpoints. We can then use the linear interpolation technique shown in the pen above to allow for sizing the relationships between viewports automatically, all based on the user scaling the content size fluidly. Once this is implemented it will be trivial to add controls in for a custom scale, so everything can be controlled in a more visual way.

There's more to it all, but ideally I want to remove the bootstrap dependency we currently have first. There's been a large amount of work to getting to that point put forth so far, but typography is one of the bigger barriers left.

@timelsass timelsass added this to the 2.2.0 milestone May 15, 2019
@timelsass timelsass self-assigned this May 15, 2019
@jamesros161 jamesros161 added the Feature Request Feature Request label May 28, 2020
@jamesros161 jamesros161 added this to Backlog in BACKLOG May 28, 2020
@jamesros161 jamesros161 moved this from Backlog to Next in BACKLOG May 29, 2020
@jamesros161 jamesros161 moved this from Next to Soon in BACKLOG Jun 2, 2020
@jessecowens
Copy link
Member

@jamesros161 this feature has been requested by another user in the BoldGrid Support Forums.

@jamesros161 jamesros161 added this to To Do in 2.9.5 via automation Sep 29, 2021
@jamesros161 jamesros161 removed this from Soon - DEPRECATED - please do something with these in BACKLOG Sep 29, 2021
@jamesros161 jamesros161 moved this from To Do to Push to Next Project in 2.9.5 Sep 29, 2021
@nicolepaschen

This comment has been minimized.

@jamesros161

This comment has been minimized.

@jamesros161 jamesros161 mentioned this issue Dec 7, 2021
@jamesros161 jamesros161 modified the milestones: 2.2.0, Stable Dec 9, 2021
@nicolepaschen

This comment has been minimized.

@nicolepaschen

This comment has been minimized.

@nicolepaschen

This comment has been minimized.

2.9.5 automation moved this from Push to Next Project to Done Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
2.9.5
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants