Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support cancellation token for Task #49

Closed
wants to merge 1 commit into from
Closed

Add support cancellation token for Task #49

wants to merge 1 commit into from

Conversation

pddkhanh
Copy link

Hi team,

First of all, thank you for your great work. I've used Bolts-ObjC and now migrating to BoltsSwift, I used BFCancellationToken on the old project, so I've tried to implement the CancellationToken for this Swift version. Please help to review it and suggest me to fix or improve it. This is the first time I create the Pull Request. So please patient if I missed somethings.

Thanks

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@serejahh
Copy link

serejahh commented Feb 28, 2017

Hi @nlutsenko! Could you check the PR? We'd really like to have the feature :)

@gapl
Copy link

gapl commented Apr 24, 2017

Are there any plans to merge this in?

@facebook-github-bot
Copy link
Contributor

@itleo31 I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@pddkhanh pddkhanh closed this Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants