New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4.0 Support #64
Conversation
Hey @akwilliamson, sorry I took over your Pull Request #62. This is about the same amount of changes for the core library, but also includes changes to enable warnings introduced in Xcode 9 and fully fix all the warnings introduced in Swift 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currentTestName
is still defined and used elsewhere. Should it be removed entirely? Regardless, the comment about Swift 2.1 ~> Swift 2.2 is outdated in the Tests/XCTestCase+TestName.swift
where currentTestName
is defined.
Looks good to me. |
👍 thanks ! |
Includes all the changes required to support Swift 4.0
Also cleans up tests, since it's finally possible with Swift 4.
Superseds and closes #62
Fixes #59
Fixes #61