Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion to Swift 5 #90

Closed
wants to merge 6 commits into from
Closed

Conversion to Swift 5 #90

wants to merge 6 commits into from

Conversation

antoinelamy
Copy link

@antoinelamy antoinelamy commented Sep 26, 2019 •
edited

  • All the content from @bpisano-luna PR
  • Remove the added SWIFT_VERSION build setting in project file
  • Run Swift 5 tests on Xcode 10.2
  • Change swift_version in podspec

@antoinelamy
Copy link
Author

Will there finally be a Swift 5 release? 🤞

@antoinelamy
Copy link
Author

@nlutsenko all good?

@mbientlab
Copy link

Hey team, would you kindly update to swift 5? If you need any support, let us know!

@nlutsenko
Copy link
Member

nlutsenko commented Sep 28, 2019 •
edited

Hey guys, sorry, it's been a while.
Let me look into making it happen today.
Should have a new release by end of this weekend.
Thank you for your patience ;)

@mbientlab
Copy link

You rock! I've been waiting for this and I'm super stoked. Thanks Nikita!

@nlutsenko nlutsenko mentioned this pull request Sep 28, 2019
Merged
@nlutsenko
Copy link
Member

New release is coming tomorrow morning.
Also going to include SwiftPM support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@antoinelamy @mbientlab @nlutsenko @facebook-github-bot @bpisano-luna