feat: accept 0-conf for non RBF swap outputs #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So afa I understand, the middle ware just sets these thresholds and accepts 0 conf up to this. No frontend/user involvement, correct (this wouldn't be possible since boltz can't know if it's a RBF tx or not beforehand)? |
michael1011
force-pushed
the
zero-conf
branch
4 times, most recently
from
69e32e0
to
8c28a75
Compare
ImmanuelSegol
approved these changes
Jun 8, 2019
peartobear
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the backend for accepting 0-conf swaps. In order to accept 0-conf transactions in a safely manner, one has to verify that the transaction does not signal BIP-125 RBF. I added that logic to the
SwapNurseryand added an additional condition to accepting 0-conf transactions: the middleware has to explicitly allow 0-conf for that specific swap when creating it. This allows for accepting 0-conf for low amounts but forcing the user to wait for bigger swaps.