New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: claim swap after one confirmation #26

Merged

michael1011 merged 1 commit into master from swapmanager-listen

Dec 10, 2018

Member

michael1011 commented Dec 9, 2018

Before this PR boltz would claim the swap once the lockup transaction is found in the mempool which is not optimal because:

of RBF and simply because one should not rely on the immutability of transactions in the mempool
if a transaction is confirmed before it reaches the mempool of the node to which boltz is connected boltz would not find the lockup transaciton

From now on boltz will claim the swap after one confirmation.


          fix: claim swap after one confirmation

4f23e13

michael1011 requested review from ImmanuelSegol and peartobear

December 9, 2018 19:32

ImmanuelSegol approved these changes

View reviewed changes

michael1011 merged commit bee35ea into master

michael1011 deleted the swapmanager-listen branch

December 10, 2018 06:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment