feat: add youtube link and create footer nav #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michael1011
requested changes
Feb 12, 2024
src/components/Nav.tsx
Outdated
Comment on lines
65
to
69
| <Show when={statusUrl}> | ||
| <a class="external" target="_blank" href={statusUrl}> | ||
| {t("status")} | ||
| </a> | ||
| </Show> |
There was a problem hiding this comment.
Nack
How often do you click a status link? Almost never. Makes no sense to show it to users all the time
There was a problem hiding this comment.
plus the web app will scream in your face if sth is not working anyways.
|
closes #445 add youtube link and remove blog link from footer move status link from footer to main nav
dni
changed the title
kilrau
approved these changes
Feb 12, 2024
michael1011
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #445
add youtube link
and add footer nav