Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: intermediate step when uploading refundjson and proper error #489

Merged
merged 7 commits into from Mar 8, 2024

Conversation

dni
Copy link
Member

@dni dni commented Feb 24, 2024

closes #470
closes #481

screenshot-1708772817

screenshot-1708774513

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Mar 8, 2024 2:31pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Mar 8, 2024 2:31pm

Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests

src/i18n/i18n.ts Show resolved Hide resolved
src/pages/Refund.tsx Show resolved Hide resolved
src/pages/Refund.tsx Show resolved Hide resolved
src/pages/Refund.tsx Show resolved Hide resolved
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#470 - good!
Screenshot from 2024-03-08 11-39-09

#481 - this should be the greyed-out button error style only, like we have everywhere else for displaying errors. Right now it's a red button that looks like it's clickable and changes on hover.
image
image

Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilrau kilrau requested a review from michael1011 March 8, 2024 14:12
@kilrau kilrau merged commit ed395bd into main Mar 8, 2024
4 checks passed
@kilrau kilrau deleted the intermediate-refund-step branch March 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants