Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading animation #493

Merged
merged 2 commits into from Mar 5, 2024
Merged

feat: add loading animation #493

merged 2 commits into from Mar 5, 2024

Conversation

dni
Copy link
Member

@dni dni commented Feb 26, 2024

closes #491

@dni dni requested a review from kilrau February 26, 2024 12:33
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Feb 27, 2024 7:21am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Feb 27, 2024 7:21am

Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

has super weird scrollbar behavior. Especially on mobile

Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scroll bar don't show for me now, looking good and loads fast enough on 2G throttling

@dni dni requested a review from michael1011 February 27, 2024 13:34
@michael1011 michael1011 merged commit 6963977 into main Mar 5, 2024
4 checks passed
@michael1011 michael1011 deleted the loading-animation branch March 5, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subtle loading animation
3 participants