Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve pasting #496

Merged
merged 5 commits into from Mar 11, 2024
Merged

feat: improve pasting #496

merged 5 commits into from Mar 11, 2024

Conversation

dni
Copy link
Member

@dni dni commented Mar 9, 2024

closes #305

it pretty though too differentiate between invalid amount (max) or invalid characters on the regex, can we do 1 error message for all i think it is sufficient?

@dni dni requested a review from kilrau March 9, 2024 10:17
@vercel Vercel
Copy link

vercel bot commented Mar 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Mar 11, 2024 11:09am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Mar 11, 2024 11:09am

kilrau
kilrau requested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the generic message is good enough 👍
    image

  • pasting a float that is within min/max works
    image
    but instead of throwing it somehow breaks the autoswitch to btc denomination if paste amount is full bitcoin and >max while in sats denomination
    image

@dni dni requested a review from kilrau March 10, 2024 14:25
kilrau
kilrau requested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fixed for me:
image

@dni dni requested a review from kilrau March 11, 2024 07:44
@dni
Copy link
Member Author

dni commented Mar 11, 2024

Still not fixed for me: image

sorry, i accidently requested a review to early :)

kilrau
kilrau requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous issue fixed. One more tiny thing: if I try pasting with cursor in the middle of this amount where max digits of the input box are reached it should throw the error as well. Right now it just doesn't paste.

image

@kilrau kilrau self-requested a review March 11, 2024 11:01
kilrau
kilrau approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael1011 michael1011 merged commit c9e4a5d into main Mar 11, 2024
4 checks passed
@michael1011 michael1011 deleted the improve-pasting branch March 11, 2024 11:43
@dni dni mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilrau kilrau kilrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve pasting
3 participants
@dni @kilrau @michael1011