fix: claim duplications #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
the effect in TxClaimed was triggering the claim, i think this is not necessary because the sweapchecker handles it. tested it manually and it works. @michael1011 i think you introduced that any reasoning behind that? introduction of claim queue so websocket updates do not overlap each other
michael1011
force-pushed
the
fix-claiming
branch
from
1de0123
to
2c84108
Compare
michael1011
force-pushed
the
fix-claiming
branch
from
2c84108
to
eee1574
Compare
michael1011
force-pushed
the
fix-claiming
branch
from
eee1574
to
1b0b068
Compare
michael1011
approved these changes
Mar 29, 2024
dni
commented
Mar 29, 2024
michael1011
force-pushed
the
fix-claiming
branch
from
99a1841
to
6e765e0
Compare
michael1011
added a commit
that referenced
this pull request
Mar 29, 2024
* fix: claim duplications the effect in TxClaimed was triggering the claim, i think this is not necessary because the sweapchecker handles it. tested it manually and it works. @michael1011 i think you introduced that any reasoning behind that? introduction of claim queue so websocket updates do not overlap each other * refator: queue of WebSocket messages to handle * fixup! * fix: handle rejected promises in lock * chore: fix wording of test --------- Co-authored-by: michael1011 <me@michael1011.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #509
the effect in TxClaimed was triggering the claim, i think this is not necessary because the sweapchecker handles it. tested it manually and it works.
@michael1011 i think you introduced that any reasoning behind that?
introduction of claim queue so websocket updates do not overlap each other