Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS native module does not match #31

Open
DriesVS opened this issue Jan 2, 2019 · 1 comment
Open

iOS native module does not match #31

DriesVS opened this issue Jan 2, 2019 · 1 comment

Comments

@DriesVS
Copy link

DriesVS commented Jan 2, 2019

the JS implementation looks for a native module named VideoPlayerManager but the Obj-c class is named RNVideoPlayer without a custom name. This does not even work. Currently wrote my own interface, I can create a PR for this to get it to work. But how can this even be in production?

@ericmgoeken
Copy link
Contributor

I had noticed this when I first pulled this down too. I should have made a pull request sooner.

@BondGoat, while that merge button is still warm, here is another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants