Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: full website #5

Merged
merged 7 commits into from Feb 16, 2022
Merged

Math magicians: full website #5

merged 7 commits into from Feb 16, 2022

Conversation

Bondok6
Copy link
Owner

@Bondok6 Bondok6 commented Feb 16, 2022

Hello there πŸ™‹β€β™‚οΈ,

Thanks for taking the time to review my project.


Live Demo 🌐

Math Magicians Project

Changes according to requirements 🧾

  • Create 3 pages: Home, CalculatorPage, and Quote.
  • Create MainHeader.jsx components that contain the Navigation.
  • Install a third-party package called react-router-dom to render the pages.
  • Create styles folder that contains all React basic styling.
  • Add Media Queries for mobile screens. (Responsive Design)
  • Use gh-pages to deploy my project.
  • Update README.md.
  • Use Gitflow.
  • Use Linters.

Gif found on CodeReviewGifs.com hosted on Giphy.com

Copy link

@BrianSammit BrianSammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟒 πŸ‘

Hello @Bondok6,
Your project is complete! There is nothing else to say other than... Great job πŸ‘
Congratulations! πŸŽ‰

TO HIGHLIGHT:

  • Your project is professional
  • Your repo is professional
  • Well structured files
  • Great job working on the routes
  • Your app is working properly

Now you can merge this branch and move on πŸ₯‡
HAPPY CODING AND GOOD LUCK WITH THE COMMING ONES 🀞 πŸ€

well-1

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Bondok6 Bondok6 merged commit a0e1ece into develop Feb 16, 2022
@Bondok6 Bondok6 deleted the pages branch February 16, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants