New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math magicians: tests #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bondok6 and @carloshs1994,
Status: Approved βοΈ
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! π
Cheers and Happy coding!πππ
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
π€ **Kyrillos Hany** | ||
|
||
- GitHub: [@Bondok6](https://github.com/Bondok6) | ||
- LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle) | ||
- LinkedIn: [LinkedIn](https://www.linkedin.com/in/kyrillos-hany/) | ||
|
||
π€ **Carlos Herver** | ||
|
||
- GitHub: [@Carlos](https://github.com/carloshs1994) | ||
- LinkedIn: [LinkedIn](https://www.linkedin.com/in/carloshs94/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [OPTIONAL] It would be good to add instructions on how to run the tests in the README by adding the command to run the test so that users can easily find all commands that are needed to run your app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julie-ify, thank you for your feedback. I will do it π
Hello there πββοΈ,
Thanks for taking the time to review our project.
Live Demo π
Math Magicians Project
Changes according to requirements π§Ύ
__tests__
folder that contain all test files.operate.js
andcalculate.js
files.react-testing-library
to simulate user interaction.README.md
.Gitflow
.Linters
.Jest