Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: tests #6

Merged
merged 7 commits into from Feb 16, 2022
Merged

Math magicians: tests #6

merged 7 commits into from Feb 16, 2022

Conversation

Bondok6
Copy link
Owner

@Bondok6 Bondok6 commented Feb 16, 2022

Hello there πŸ™‹β€β™‚οΈ,

Thanks for taking the time to review our project.


Live Demo 🌐

Math Magicians Project

Changes according to requirements 🧾

  • Create __tests__ folder that contain all test files.
  • Add unit tests for the operate.js and calculate.js files.
  • Create unit tests for all React components.
  • Use Jest snapshots to test the components.
  • Use react-testing-library to simulate user interaction.
  • Update README.md.
  • Use Gitflow.
  • Use Linters.
  • Use Jest

Gif found on CodeReviewGifs.com hosted on Giphy.com

Copy link

@julie-ify julie-ify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bondok6 and @carloshs1994,

Status: Approved βœ”οΈ

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines 43 to +51
πŸ‘€ **Kyrillos Hany**

- GitHub: [@Bondok6](https://github.com/Bondok6)
- LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle)
- LinkedIn: [LinkedIn](https://www.linkedin.com/in/kyrillos-hany/)

πŸ‘€ **Carlos Herver**

- GitHub: [@Carlos](https://github.com/carloshs1994)
- LinkedIn: [LinkedIn](https://www.linkedin.com/in/carloshs94/)
Copy link

@julie-ify julie-ify Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [OPTIONAL] It would be good to add instructions on how to run the tests in the README by adding the command to run the test so that users can easily find all commands that are needed to run your app.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julie-ify, thank you for your feedback. I will do it πŸ‘Œ

@carloshs1994 carloshs1994 merged commit 8d19fc3 into develop Feb 16, 2022
@Bondok6 Bondok6 deleted the testing-pair-prog branch February 17, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants