Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for Items counter #26

Merged
merged 7 commits into from Feb 2, 2022
Merged

Test for Items counter #26

merged 7 commits into from Feb 2, 2022

Conversation

Bondok6
Copy link
Owner

@Bondok6 Bondok6 commented Feb 2, 2022

Hi @andres-condezo 🙋‍♂️

Changes

  • I created a __tests__ folder.
  • I created getMeals.test.js file inside this folder.
  • I tested the function to ensure that the items counter is covered with unit tests using Jest.

@andres-condezo
Copy link
Collaborator

Hi @Bondok6 👋

Status: Approved ✔️

Great job so far!

Highlights

  • Good job handling the tests.✔️
  • No linter errors ✔️
  • Descriptive pull request ✔️

Your task is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

@Bondok6
Copy link
Owner Author

Bondok6 commented Feb 2, 2022

Thank you @andres-condezo 🙏🎉

@Bondok6 Bondok6 merged commit f0728c1 into develop Feb 2, 2022
@Bondok6 Bondok6 deleted the test-meals-length branch February 6, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-condezo andres-condezo Awaiting requested review from andres-condezo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bondok6 @andres-condezo