Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tabindex for 'Remember Me' at login, lack of keyboard toggle #1476

Closed
seanosullivanuk opened this issue May 31, 2019 · 1 comment

Comments

@seanosullivanuk
Copy link

commented May 31, 2019

The 'Remember Me' checkbox on the login page is an SVG item, which doesn't yet have a tabindex attribute for keyboard navigation. Support for this is rudimentary, but having it within the markup would at least provide the functionality for users of Chrome, Edge Insider and Firefox.

Also, I use the space bar to toggle check boxes, but being an SVG this doesn't work. For wider compatibility and accessibility, may I request the SVG element changed to a checkbox input type?

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Thanks for reporting @seanosullivanuk, This goes well with the intended accessibility improvements for the next release.

The checkbox itself is actually a styled span inside a label, the SVG is just the check mark itself.
I've now updated the use of custom checkboxes to be tab-focusable and to have keyboard toggle functionality in addition to now having aligned accessibility markup.

In an ideal world we'd use normal checkboxes but they're unfortunately variant across operating systems while being hard to customize directly.

These changes will be in the next patch release.

@ssddanbrown ssddanbrown modified the milestones: v0.26.3, v0.27.0 Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.