Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report]: OIDC token failures fail to notify upon errors #3264

Closed
2 tasks done
ssddanbrown opened this issue Feb 13, 2022 · 0 comments
Closed
2 tasks done

[Bug Report]: OIDC token failures fail to notify upon errors #3264

ssddanbrown opened this issue Feb 13, 2022 · 0 comments
Labels
🐛 Bug
Milestone
v22.02

Comments

@ssddanbrown
Copy link
Member

ssddanbrown commented Feb 13, 2022 •
edited

Describe the Bug

Errors during ID token validation fail to notify back to the user.
This is due to an extra redirect in the path

  • GET /oidc/callback
  • GET /
    • Not authed, Redired to /login
    • Flashed session lost
  • GET /login

Steps to Reproduce

Setup OIDC with:

OIDC_ISSUER_DISCOVER=false
OIDC_PUBLIC_KEY=https://example.com

Expected Behaviour

"ID token validate failed with error: Failed to read signing key with error: Unexpected type of key value provided" message should display to user.

Exact BookStack Version

v21.12.5

PHP Version

No response

Hosting Environment

Dev

  • Could do with cleaning up OpenIdConnectException usage while at it. Probably keep to normal exception then convert at controller level.
  • Ensure case added to tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Milestone
v22.02
Development

No branches or pull requests
1 participant
@ssddanbrown