Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up command classes #4225

Closed
ssddanbrown opened this issue May 6, 2023 · 0 comments · Fixed by #4262
Closed

Clean up command classes #4225

ssddanbrown opened this issue May 6, 2023 · 0 comments · Fixed by #4262
Labels
🏭 Back-End 🔧 Maintenance
Milestone
v23.06

Comments

@ssddanbrown
Copy link
Member

Update our command classes to follow a common convention. Including:

  • Update to inject via the handle method (Advised approach in Laravel docs).
  • Standardise how response codes are returned (And ensure they are) (int vs SymfonyCommand::[SUCCESS/FAILURE]).
    • Laravel internal commands appear to just use ints, is probably the cleaner option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏭 Back-End 🔧 Maintenance
Milestone
v23.06
Development

Successfully merging a pull request may close this issue.

Command cleanup & alignment BookStackApp/BookStack
1 participant
@ssddanbrown