Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachments endpoints #123

Open
JovicaSusa opened this issue May 11, 2018 · 7 comments
Open

Add attachments endpoints #123

JovicaSusa opened this issue May 11, 2018 · 7 comments

Comments

@JovicaSusa
Copy link
Contributor

We need to add inbox attachments endpoints.

@JovicaSusa
Copy link
Contributor Author

@StoneFrog @Azdaroth I've set client to send base64 encoded string for attachments file, is that the right way to handle upload of the attachments? If so we need to change inbox uploader on core to use carrierwave-base64 gem.

@Azdaroth
Copy link
Member

@JovicaSusa try uploading something on Core in dev and see if it works

@StoneFrog
Copy link
Contributor

@JovicaSusa doesn't remote_file_url work :P ?

@JovicaSusa
Copy link
Contributor Author

JovicaSusa commented May 11, 2018

@Azdaroth It worked when I've added carrierwave-base64 gem to Core and changed inbox uploader to

mount_base64_uploader :file, InboxFileUploader

@JovicaSusa
Copy link
Contributor Author

@StoneFrog Not sure what to do remote_file_url? Where that comes from 😄

@StoneFrog
Copy link
Contributor

@JovicaSusa I think we should support both as we do now with photos. Basically you should be able to pass file as base64 encoded string or remote_file_url as external url.

@JovicaSusa
Copy link
Contributor Author

JovicaSusa commented May 11, 2018

@StoneFrog Ok, thanks. I'll check how photos work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants