Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of old note failing #393

Closed
fnsne opened this issue Mar 28, 2020 · 12 comments · Fixed by #412
Closed

Import of old note failing #393

fnsne opened this issue Mar 28, 2020 · 12 comments · Fixed by #412
Labels
bug 🐛 Issue concerns a bug. won’t fix ❌ Issue will not be fixed.
Milestone

Comments

@fnsne
Copy link

fnsne commented Mar 28, 2020

Current behavior

I follow the step of import .cson file from old Boostnote.
But after I drop the .cson file, the form shows Invalid file: XXXXX.cson.
註解 2020-03-28 165706
And After I pressed Upload, I got Successfully imported 0 notes..
註解 2020-03-28 165827

Is that a bug or my forgot to do something?
Thanks.

Operation System: Windows 10
Language: Chinese

@Rokt33r
Copy link
Member

Rokt33r commented Mar 29, 2020

Sorry for making you confused. The importing feature is not fully ready yet. I assume the note should be a snippet note which the new app doesn't support anymore. So, if you need to use the note, please keep using the old app. We will keep maintaining it until most of features of the old app are ready to use.

If the cson file is not snippet notes, please share the content so we can reproduce the problem.

@Rokt33r Rokt33r added the needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. label Mar 29, 2020
@fnsne
Copy link
Author

fnsne commented Mar 29, 2020

Thank for the reply.
The cson file is markdown notes.
Here is one of notes that cannot be imported.

createdAt: "2020-01-14T07:00:14.251Z"
updatedAt: "2020-03-29T06:59:09.521Z"
type: "MARKDOWN_NOTE"
folder: "fa1c2e9fba092f0b94b1"
title: "TDD DIworkshop"
tags: [
  "91"
]
content: '''
  # TDD DIworkshop
  
  ## testcases
  case|accountId| password|otp|hashedPassword|passwordFromDb| otpFromService|result
  ---|---|---|---|---|---|---|---|----
  is_valid| "joey"|"1234"| "right otp"|"hashed password"|"hashed password"| "right otp"|true
  is_invalid| "joey"| "1234"| "wrong otp"| hased password"| "hashed password"| "right otp"| false
'''
linesHighlighted: []
isStarred: false
isTrashed: false

@Rokt33r
Copy link
Member

Rokt33r commented Mar 29, 2020

Hmm It might be a bug. Thanks for sharing.

@Rokt33r Rokt33r added the bug 🐛 Issue concerns a bug. label Mar 29, 2020
@Flexo013 Flexo013 changed the title cannot import from old note .cson Import of old note failing Apr 5, 2020
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Apr 7, 2020

I can't reproduce this bug, I was able to import this note just fine on Ubuntu web version. Maybe error at read file stage?

@fnsne
Copy link
Author

fnsne commented Apr 7, 2020

@ZeroX-DG
Maybe because I'm using Windows and my OS language is Chinese?

@Flexo013 Flexo013 removed the needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. label Apr 7, 2020
@Flexo013
Copy link
Contributor

Flexo013 commented Apr 7, 2020

This is definitely a bug. I can reproduce this with all kinds of valid notes from the legacy app.

Even a simple note with 1 character fails to import when using the web app in Chrome on Windows 10.

createdAt: "2020-04-07T05:56:39.347Z"
updatedAt: "2020-04-07T05:56:41.284Z"
type: "MARKDOWN_NOTE"
folder: "5492e730e2e37ab114d6"
title: "a"
tags: []
content: "a"
linesHighlighted: []
isStarred: false
isTrashed: false

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Apr 7, 2020

Ah I was able to reproduce the bug in the currently deployed version of Boostnote but not on the master version of Boostnote...maybe it been fixed sometime after deployed?

@WyekS
Copy link

WyekS commented Apr 9, 2020

I have the same bug.
I used to Boostnote on Arch Linux and Windows and I used to Dropbox to share notes between this systems.

Now, Boostnote was updated on Windows and I can't load the old notes on my Dropbox :(
I have many notes saved...

I I tried to change the CR/LF encoding in the CSON files without success.

Thanks you and regards

@Rokt33r
Copy link
Member

Rokt33r commented Apr 9, 2020

@WyekS @Flexo013 @fnsne Hmm I'm thinking that rather than keeping the broken importing features, why don't we just delete this feature and focus on File system based storage which will cover this problem too. How do you think?

@Rokt33r
Copy link
Member

Rokt33r commented Apr 9, 2020

FYI, I'm expecting that the file system based storage should be completely landed before the end of this June.

@Rokt33r
Copy link
Member

Rokt33r commented Apr 11, 2020

I'll delete the current broken importing feature from v0.4. But it will be back along with File system based storage. @WyekS @Flexo013 @fnsne

@WyekS
Copy link

WyekS commented Apr 13, 2020

Thanks so much @Rokt33r :)

@Flexo013 Flexo013 added the won’t fix ❌ Issue will not be fixed. label Apr 13, 2020
@Rokt33r Rokt33r added this to the v0.4.0 milestone Apr 19, 2020
@Rokt33r Rokt33r linked a pull request Apr 19, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. won’t fix ❌ Issue will not be fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants