Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Deleting folder in boostnote removes all notes within that folder :-( #975

Closed
huzibizi opened this issue May 28, 2021 · 4 comments
Closed

Comments

@huzibizi
Copy link

Current behavior

When you create a folder and some notes within that folder, then rename that folder, the notes that were within that folder all disappear and can't seem to be recovered.

Expected behavior

All notes within a folder should remain when that folder is renamed.

Steps to reproduce

  1. Create a folder called 'folder'
  2. Right-click on the folder, click on 'new note'. (or use the buttons next to the folder name)
  3. Name the note 'note', and write some info inside.
  4. Right click on the folder, click on 'rename folder'.
  5. Rename to 'folder 2'.
  6. any notes that were inside the folder will disappear :'(

Environment

Desktop/Web

  • Boost Note.next version: 0.17.1
  • OS version and name: Windows 10 Education x64
@Komediruzecki
Copy link
Contributor

Komediruzecki commented May 29, 2021

Hi, huzibizi,

I managed to reproduce the issue, but this happens only in PouchDB storage, i.e. legacy cloud or local storage, not file system storage.

Since we deprecated legacy cloud storage and local storage, please convert your storage to file system storage or new cloud one if you want.

I highly recommend this as legacy cloud storage is no longer synced, so there is no benefit having it, I'll investigate more why this happens, it could be due to failed sync.

It also happens to me that when I actually refresh the application notes appear again i.e. they are correctly renamed and updated in tree. Can you try refreshing and see if notes perists where they should be? Might be only an sidebar tree view not showing them!

@Komediruzecki
Copy link
Contributor

Komediruzecki commented May 29, 2021

Hi, huzibizi,

Here I am again, I reproduced the issue on development setup, it seems that notes are overwritten because somehow there are 2 duplicate folders with same name and it fetches notes from first, then fetches it from second, but when updating the storage it overwrites it last with folder with no notes inside.

Anyhow, notes are not deleted.

Please, to restore your notes, just convert that storage where you renamed folders into file system storage (let me know if you need help doing that, but just go to Preferences | Space | Convert into File System Based Storage and convert the notes). Or refresh the application (as described in above comment), notes could reappear in correct places.

This will retrieve all your lost notes and you will be in supported storage space.

image

@huzibizi
Copy link
Author

huzibizi commented Jun 3, 2021

Hi, huzibizi,

Here I am again, I reproduced the issue on development setup, it seems that notes are overwritten because somehow there are 2 duplicate folders with same name and it fetches notes from first, then fetches it from second, but when updating the storage it overwrites it last with folder with no notes inside.

Anyhow, notes are not deleted.

Please, to restore your notes, just convert that storage where you renamed folders into file system storage (let me know if you need help doing that, but just go to Preferences | Space | Convert into File System Based Storage and convert the notes). Or refresh the application (as described in above comment), notes could reappear in correct places.

This will retrieve all your lost notes and you will be in supported storage space.

image

thank you, the notes didnt come back though, maybe cause i deleted the folder to avoid making the same mistake lol

@Komediruzecki
Copy link
Contributor

Komediruzecki commented Jun 3, 2021

Hi, huzibizi,
Here I am again, I reproduced the issue on development setup, it seems that notes are overwritten because somehow there are 2 duplicate folders with same name and it fetches notes from first, then fetches it from second, but when updating the storage it overwrites it last with folder with no notes inside.
Anyhow, notes are not deleted.
Please, to restore your notes, just convert that storage where you renamed folders into file system storage (let me know if you need help doing that, but just go to Preferences | Space | Convert into File System Based Storage and convert the notes). Or refresh the application (as described in above comment), notes could reappear in correct places.
This will retrieve all your lost notes and you will be in supported storage space.
image

thank you, the notes didnt come back though, maybe cause i deleted the folder to avoid making the same mistake lol

Hi huzibizi,

If you deleted the folder the notes contained in the folder would go to trash, again would not be completely deleted.
But I wonder if maybe they weren't any notes at that time inside folder, so deleting the folder might not trash anything, and later the notes would be hanging somewhere - but I think it would still be possible to get to them.

As for future, the new update of the boost note next will completely discard pouchDB storage and come with new sidebar, so in general this problem would not exist anymore.

I'll close the issue, please reopen if you have anything more to add!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants