Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code preview error #2217

Closed
tao996 opened this issue Jul 19, 2018 · 4 comments
Closed

code preview error #2217

tao996 opened this issue Jul 19, 2018 · 4 comments
Labels
bug 🐛 Issue concerns a bug.

Comments

@tao996
Copy link

tao996 commented Jul 19, 2018

Current behavior

  1. code preview show error

2018-07-19 21 34 09

php $ and single quotes error

  1. in the editor mode, when tap one * at the begin of new line, it become to **

Environment

  • Version :0.11.8 (0.11.8)
  • OS Version and name :10.13.6 (17G65)
@Rokt33r
Copy link
Member

Rokt33r commented Jul 19, 2018

We still have a bug when sanitizing markdown. It is broken now. But, you can disable it!

screen shot 2018-07-20 at 0 15 31

@kulkarniamit
Copy link

Exported HTML also has an issue rendering it.

Markdown:

boostnote-issue-1

Rendered:

boostnote-issue-2

HTML Output

boostnote-issue-3

Environment

Boostnote version: 0.11.8
OS: Ubuntu 14.04 LTS

@Redsandro
Copy link
Contributor

Redsandro commented Jul 21, 2018

I installed latest Boostnote (because I reinstalled Linux) and now all my code snippets are broken with &quote;, ' (#2220) and other encodings or escapes (#2227). Snippets become hard to read. I cannot use the 'copy snippet' button, which I use daily, anymore. 😠

@Rokt33r You really can't release a feature that causes something to be so blatantly broken.

Ideally there will be tests that will check the parsed output. Using your favorite CI with a github hook, any PR would be verified against these tests, and if something breaks, it can not be merged.

-update-

I see there are already tests? Are they ignored?
I guess code block test was just added. 👍

-update-

I see @ZeroX-DG created #2230 to fix this. Please test/merge soon.

@Rokt33r
Copy link
Member

Rokt33r commented Jul 22, 2018

@Redsandro I'm sorry. I'll check it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

No branches or pull requests

4 participants