Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title fetching fails when TOC is present #3080

Open
arcturus140 opened this issue Jun 14, 2019 · 1 comment
Open

Title fetching fails when TOC is present #3080

arcturus140 opened this issue Jun 14, 2019 · 1 comment
Labels
bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work.

Comments

@arcturus140
Copy link
Contributor

Current behavior

When pasting a URL into Markdown Note convertion into markdown link fails in a certain situation.

Expected behavior

  1. copy https://www.google.com/
  2. paste into markdown note
  3. result: [Google](https://www.google.com/)

Steps to reproduce

  1. create TOC at line 1
  2. paste link below that
  3. paste link below that

Test result 1

MNWE used to illustrates the issue:
<!-- toc -->



<!-- tocstop -->

https://www.google.com/

[Google](https://www.google.com/)

Note that the first link failed to be converted. TOC must be there to fail.

Test result 2

Note that I am using an old version. The behaviour is different on #2994 (85bb0c1). See test result 2 for #2994. I did not test on master but I am assuming it can be replicated.

MNWE used to illustrates the issue:
<!-- toc -->

- [https://www.google.com/](#httpswwwgooglecom)
- [<https://www.google.com/>](#httpswwwgooglecom-1)
- [<https://www.google.com/>](#httpswwwgooglecom-2)
- [<https://www.google.com/>](#httpswwwgooglecom-3)

<!-- tocstop -->

# https://www.google.com/

# <https://www.google.com/>

# <https://www.google.com/>

# <https://www.google.com/>

<https://www.google.com/>

<https://www.google.com/>

Note that all links failed to be converted. TOC must be there to fail.

Environment

  • Version : 0.11.12
  • OS Version and name : 16.04 Ubuntu
@ZeroX-DG ZeroX-DG added bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work. labels Jun 14, 2019
@ZeroX-DG
Copy link
Member

Thank you for reporting!

@Flexo013 Flexo013 changed the title fail to fetch title Title fetching fails when TOC is present Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work.
Projects
None yet
Development

No branches or pull requests

2 participants