Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Note/Attention/etc containers #474

Closed
pseigler opened this issue May 12, 2020 · 8 comments
Closed

Support for Note/Attention/etc containers #474

pseigler opened this issue May 12, 2020 · 8 comments
Assignees
Labels
feature request 🌟 Issue is a new feature request.
Projects

Comments

@pseigler
Copy link

pseigler commented May 12, 2020

Current behavior

The original Boostnote desktop client would allow containers using

!!! note/attention/etc Note Title
Testing a block
!!!

The current build of Boost Note.next renders the same markdown as -

image

Expected behavior

The container would render as follows -

image

Environment

Desktop

  • Boost Note.next version: 0.4.1
  • OS version and name: Windows 10 / latest build

BTW

The Boost Note legacy client is the best markdown editor out there. I'm really excited to start using the .next version. I know there's work still to be done, but hoping most of the markdown features, like the ability to create containers, comes with .next. Awesome job everyone!!

@arcturus140
Copy link
Contributor

Note that docarys/markdown-it-admonition#6 does not support nested admonitions. Maybe https://github.com/nebrelbug/react-admonitions is a good alternative - it does support nested admonitions, as well.

It uses the following format:

<Admonition type='note' title='Do not do this'>
    Remember that
</Admonition>

I don't know if it can be integrated to be used with markdown so it uses the format

!!! note Do not do this
Remember that
!!!

@SinclairHudson
Copy link

+1

@myicq
Copy link

myicq commented Aug 24, 2020

This type of markdown is one of the reasons I started using Boostnote. Sad to see that this markup, along with others, has now gone. Kind of reminds me of Skype: newer, better, smarter (but all good features gone). Hope for the best to come.

@chayac
Copy link

chayac commented Sep 16, 2020

+1 on this. I started using Boostnote because I wanted to take advantage of features like this, so I hope they will return in the new version!

@AlejandroRodarte
Copy link

AlejandroRodarte commented Dec 7, 2020

Another +1. I frequently use admonition boxes and definition lists in my notes, hoping they return in the future so I can fully migrate to the new version.

Thank you for your hard work!

@Flexo013 Flexo013 added this to To do (Medium) in Dev kanban Dec 12, 2020
@Rokt33r Rokt33r moved this from To do (Medium) to This sprint(Dec 12th - Dec 26th) in Dev kanban Dec 12, 2020
@Komediruzecki Komediruzecki moved this from This sprint(Dec 12th - Dec 26th) to In progress in Dev kanban Dec 16, 2020
@Komediruzecki Komediruzecki moved this from In progress to Done in Dev kanban Jan 3, 2021
@Komediruzecki
Copy link
Contributor

Komediruzecki commented Jan 3, 2021

I'll close this as this is resolved with #727.
For admonitions, please use new tag syntax: triple colon operator (":::" ) instead of triple exclamation mark ("!!!") with appropriate keyword, one of: 'note', 'tip', 'warning 'caution', 'info'. Examples can be seen in PR description.

@AlejandroRodarte
Copy link

Outstanding. Will be looking forward to this recent addition.

Thanks to all the team behind this project!

@chayac
Copy link

chayac commented Jan 17, 2021

Awesome, super excited for this! Excited to try it out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request.
Projects
No open projects
Dev kanban
  
Done
Development

No branches or pull requests

8 participants