Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 Windows Support #647

Open
justrach opened this issue Oct 15, 2020 · 4 comments
Open

ARM64 Windows Support #647

justrach opened this issue Oct 15, 2020 · 4 comments
Assignees
Labels
funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement.

Comments

@justrach
Copy link

justrach commented Oct 15, 2020

Issuehunt badges

Current behavior

Emulated in 32 bit windows emulator

Expected behavior

A native build would be great since Electron recently added 64 bit support for ARM64 :)
Load in ARM64, however, it loads in the emulation layer, leading to a lack of battery loss.

Steps to reproduce

Are the binaries open to compile it for ARM64, so that there can be unofficial releases.

Environment

ARM64 for Windows10

Desktop/Web

  • Boost Note.next version: 0.9.0
  • OS version and name: Windows 10

IssueHunt Summary

Backers (Total: $20.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

@Flexo013 Flexo013 added the feature request 🌟 Issue is a new feature request. label Oct 24, 2020
@Rokt33r Rokt33r added the assigned to core 🦹 Issues are taken care of by the core team actively label Aug 23, 2021
@Rokt33r Rokt33r self-assigned this Aug 23, 2021
@Rokt33r Rokt33r added help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement. and removed feature request 🌟 Issue is a new feature request. assigned to core 🦹 Issues are taken care of by the core team actively labels Aug 23, 2021
@Rokt33r
Copy link
Member

Rokt33r commented Aug 23, 2021

I don't have an arm64 windows pc. But I'm sure that adding arm64 to arch should work. Do you think you can test the building?

  1. Add arm64 to here https://github.com/BoostIO/BoostNote.next/blob/master/package.json#L250-L253
  2. Create .env file and set BOOST_HUB_BASE_URL=https://boostnote.io.
  3. Run these scripts
npm run build:electron
npm run prepack

Then you will get an executable so you can run it in your pc.

@justrach
Copy link
Author

justrach commented Aug 28, 2021

Hi, yes it works

-> Tested on M1 Mac w the M1 Chip.. Is there a way to fix that?
Ss

However, there are signing issues, but I believe that is due to the unofficial port that we would be building is that right?

@Rokt33r
Copy link
Member

Rokt33r commented Aug 31, 2021

@justrach Thanks for testing then we should provide build for arm64 too.

Tested on M1 Mac w the M1 Chip.. Is there a way to fix that?

electron-userland/electron-builder#5426 seems electron builder is supporting the apple silicon chip so I think we can try the same trick on M1 Mac.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 14, 2021

@boostio has funded $20.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. label Sep 14, 2021
@kazup01 kazup01 added the hacktoberfest Contribute to the Boost Note and grab the swags! https://hacktoberfest.digitalocean.com/ label Oct 4, 2021
@kazup01 kazup01 removed the hacktoberfest Contribute to the Boost Note and grab the swags! https://hacktoberfest.digitalocean.com/ label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants