Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests and E2E tests #1285

Closed
mslourens opened this issue Dec 12, 2017 · 1 comment
Closed

Add more unit tests and E2E tests #1285

mslourens opened this issue Dec 12, 2017 · 1 comment
Labels
discussion 💬 Issue concerns a discussion.

Comments

@mslourens
Copy link
Contributor

I noticed that this project contains only a couple of unit tests and no End 2 End tests at all. Shouldn't we start creating some more tests, to prevent bugs? I found this project for E2E testing of Electron apps: Spectron.
@sosukesuzuki sosukesuzuki added the discussion 💬 Issue concerns a discussion. label Jan 13, 2018
@Flexo013
Copy link
Contributor

Adding more tests is definitely a good idea. If there are pieces of code that you would like to see tests on then you are free to write them and submit PRs for them.

Alongside that you can also frequently check in on open PRs if there is code that should ideally have tests. If you find that it is present then you can post that on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion 💬 Issue concerns a discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mslourens @Flexo013 @sosukesuzuki