Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release notifications #1435

Closed
mslourens opened this issue Jan 17, 2018 · 4 comments
Closed

Refactor release notifications #1435

mslourens opened this issue Jan 17, 2018 · 4 comments
Labels
discussion 💬 Issue concerns a discussion.

Comments

@mslourens
Copy link
Contributor

In order to fix issue #1388 (where we need to compare the current appVersion with the latest release) I suggest to change the notifications:

  • get the latest release by fetching: https://api.github.com/repos/BoostIO/Boostnote/releases/latest
  • parse the response and retrieve these properties:
    • tag_name - for the comparison with the app.getVersion() result (after stripping the leading 'v')
    • body - for the info in the notification, which should be filled in when the release is created and should not contain too much info, otherwise the notification will get too long.
  • only display the notification if there is a difference in the comparison between the tag_name and the current appVersion (which will fix Info for new Version can be misleading #1388)
  • remove the repo BoostIO/notification
@Rokt33r Rokt33r added the discussion 💬 Issue concerns a discussion. label Jan 18, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Jan 18, 2018

get the latest release by fetching: https://api.github.com/repos/BoostIO/Boostnote/releases/latest

We can do it from here. https://api.github.com/repos/BoostIO/boost-releases/releases/latest

But I'm afraid that its body has too much information.

@mslourens
Copy link
Contributor Author

will it take so much more time to process? I think this way it more consistent with Github and you need more info in order to compare the current version of your app with the latest release.

@Rokt33r
Copy link
Member

Rokt33r commented Jan 19, 2018

Fixing #1388 is quite simple. Showing the body of a release is not that simple. We have to decide where to show it.(Visual design issue)

@Flexo013
Copy link
Contributor

The green notification is no longer used for announcing new version, so adding logic to compare it to the current installed version isn't quite needed anymore.

If the notification will be used for this in the future then this will have to implemented before such notifications can be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion 💬 Issue concerns a discussion.
Projects
None yet
Development

No branches or pull requests

3 participants