Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to render markdown in Publish blog feature #1675

Closed
lijinglue opened this issue Mar 13, 2018 · 2 comments
Closed

Fail to render markdown in Publish blog feature #1675

lijinglue opened this issue Mar 13, 2018 · 2 comments
Labels
bug 🐛 Issue concerns a bug.

Comments

@lijinglue
Copy link
Contributor

Repo step:
Try the new publish blog feature. Nothing happens. Open the dev tools you'll find the error prompt.

Expected result:
Blog correctly rendered as html and post to wordpress

Env:
Win10

Uncaught TypeError: _markdown2.default.render is not a function
at WrappedComponent.publishMarkdownNow (file:///C:/Users/user/AppData/Local/boost/app-0.11.2/resources/app/compiled/main.js:54745:38)
at file:///C:/Users/user/AppData/Local/boost/app-0.11.2/resources/app/compiled/main.js:54713:17

Seems to be a module resolve issue? I did try the feature in the feature branch, but seems the new version is not working now.

@lijinglue
Copy link
Contributor Author

turns out to be the change in lib/markdown broke the feature, i have a small hotfix for it

@Flexo013
Copy link
Contributor

Flexo013 commented Aug 1, 2019

Fix was merged.

@Flexo013 Flexo013 closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

No branches or pull requests

3 participants