Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use locally installed plantuml (instead of server) #2079

Open
jonblack opened this issue Jun 14, 2018 · 4 comments
Open

Use locally installed plantuml (instead of server) #2079

jonblack opened this issue Jun 14, 2018 · 4 comments
Labels
feature request 🌟 Issue is a new feature request.

Comments

@jonblack
Copy link

When a plantuml diagram has invalid syntax a call is made to plantuml which returns a 404 response, and then the error image is shown.

I would expect a locally installed version of plantuml to be used for all generation. I'm not sure if the plantuml demo server is used for all plantuml generation but I hope not since that would mean it won't work when there's no internet connection (and if the plantuml demo server ever disappears).

It also has privacy implications. Anyone sniffing packets on the same network, compromised routers, and even your beloved ISP can very easily see the images you're creating.

@ehhc
Copy link
Contributor

ehhc commented Jun 14, 2018

you can change which planuml server you use in the settings (Preferences -> Interface -> PlantUML Server (at the bottom of the settings)).
So if you have a local planUML server running, you can simply use this :)

@sosukesuzuki sosukesuzuki added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Jun 14, 2018
@sosukesuzuki
Copy link
Member

@jonblack Is this issue resolved?

@jonblack
Copy link
Author

It's not that nice to have to setup a local plantuml server just for boostnote, and I can imagine some users aren't able to do that since the you need to clone the repository and either run maven or the docker image, which is quite technical.

@sosukesuzuki sosukesuzuki added feature request 🌟 Issue is a new feature request. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jun 14, 2018
@sosukesuzuki
Copy link
Member

I see, I put the label "feature request":+1:

@Flexo013 Flexo013 changed the title Use locally installed plantuml Use locally installed plantuml (instead of server) Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request.
Projects
None yet
Development

No branches or pull requests

3 participants