New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid diagrams don't play nice with dark interface themes #2215
Comments
Haha, yeah, we need to fix it. I assume a single line of css code, which is setting a background color, should be enough. |
I noticed that Mermaid itself seems to have different themes (note the
Maybe it's just a matter of somehow activating Mermaids dark theme if Boostnote runs with a dark interface theme? I'd love to help more, but unfortunately I'm not at all familiar with Electron so I have no idea from what angle to tackle that task. |
@anothernode Fixed 馃憤 #2231 |
@BoostIO funded this issue with $30. Visit this issue on Issuehunt |
Looks like it's my lucky day 馃槅 |
yay馃帀 |
@yougotwill Don't forget to apply for the rewarding 馃槃 |
@yougotwill has started working. Visit this issue on Issuehunt |
@yougotwill has submitted output. Visit this issue on Issuehunt |
@kazup01 has rewarded. Visit this issue on Issuehunt |
Mermaid support introduced with #2173 is absolutely awesome! 馃憦馃憤
There's just a small problem with readability of texts in the diagrams when using one of the dark interface themes:
Current behavior
Some text in Mermaid diagrams in the preview panel is not readable when using one of the dark interface themes:
Expected behavior
All text in Mermaid diagrams should be readable when using one of the dark interface themes, as it is the case for light interface themes:
Steps to reproduce
Environment
The text was updated successfully, but these errors were encountered: