Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2816 Application window bigger after every restart #2820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MiloTodt
Copy link
Contributor

@MiloTodt MiloTodt commented Jan 21, 2019

Removed option in new BrowserWindow:

useContentSize Boolean (optional) - The width and height would be used as web page's size, which means the actual window's size will include window frame's size and be slightly larger. Default is false.

Which was set to true.

Boostnote now opens to the same size as previous instead of slightly larger each time.

Issue fixed

fix #2816

Type of changes

  • ✔️ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ✔️ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ✔️ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 22, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r January 22, 2019 15:46
@Rokt33r
Copy link
Member

Rokt33r commented Jan 23, 2019

I've tried this on Windows 10 but the window size is still different after I reopen the app again. @MiloTodt Did it work on your pc?

@alehmann76
Copy link

alehmann76 commented Feb 27, 2019

I tried it on a Windows 7 machine and it runs like expected with the bug fix.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Apr 6, 2020

@Flexo013 can you test this on window see if the bug is still there? if not then we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application window bigger after every restart
4 participants