Automatic update the table of content if available #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
reviewed
Feb 9, 2019
| linePossibleContainsHeadline (currentLine) { | ||
| // We can't check if the line start with # because when some write text before | ||
| // the # we also need to update the toc | ||
| return currentLine.includes('# ') |
There was a problem hiding this comment.
Why can't we? We can just replace it with '\n# ' don't you think?
There was a problem hiding this comment.
I didn't think that matching '\n# ' helps. The line starts with the first char that is't a new line.
And we should check for the '# ' because when you add to a headline with '## test' something at the beginning (new text is: 'something## test') the toc should automatic remote the entry.
ZeroX-DG
added
awaiting changes 🖊️
ZeroX-DG
approved these changes
Feb 17, 2019
| linePossibleContainsHeadline (currentLine) { | ||
| // We can't check if the line start with # because when some write text before | ||
| // the # we also need to update the toc | ||
| return currentLine.includes('# ') |
ZeroX-DG
added
approved 👍
Rokt33r
removed
the
approved 👍
… if available when a headline was modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a line with a headline was changed
(the line should contains
#) in a note with a toc, the toc generator will generate a new toc for this note.Tested use cases:
Issue fixed
#2782
Type of changes
Checklist: